Support binlog in build/restore of file-based programs #49009
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling the "-bl" (binary log) argument for file-based programs during dotnet build and restore operations.
- Adds a new utility method to separate binary log arguments.
- Refactors command parsing in the Run, Restore, and Build commands to use the new utility.
- Updates test cases to validate the new behavior.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds tests to validate binary log argument handling for build/restore commands. |
| src/Cli/dotnet/LoggerUtility.cs | Introduces a new method to separate binary log arguments from other arguments. |
| src/Cli/dotnet/Commands/Test/MSBuildUtility.cs | Refactors token separation using the new utility method. |
| src/Cli/dotnet/Commands/Run/RunCommand.cs | Updates binary log argument separation to improve consistency. |
| src/Cli/dotnet/Commands/Restore/RestoreCommand.cs | Adjusts processing of file arguments and binary log arguments for restore scenarios. |
| src/Cli/dotnet/Commands/Build/BuildCommand.cs | Similar refactoring and merging of binary log arguments during build command parsing. |
| @@ -61,6 +61,23 @@ private static FacadeLogger ConfigureDispatcher(List<BinaryLogger> binaryLoggers | |||
| return new FacadeLogger(dispatcher); | |||
| } | |||
|
|
|||
| internal static void SeparateBinLogArguments(IEnumerable<string>? args, out List<string> binLogArgs, out List<string> nonBinLogArgs) | |||
There was a problem hiding this comment.
[nitpick] Consider adding XML documentation comments for the SeparateBinLogArguments method to explain its behavior, especially the treatment of null inputs and the criteria used to separate binlog arguments.
Copilot uses AI. Check for mistakes.
| nonBinLogArgs = new List<string>(); | ||
| foreach (var arg in args ?? []) | ||
| { | ||
| if (IsBinLogArgument(arg)) |
There was a problem hiding this comment.
This will return true for -bl which causes the switch -bl to be put into binLogArgs but not the value. Is that intended?
There was a problem hiding this comment.
yes, -bl doesn't have a value, that would have to be written as -bl:value.
|
oh, I forgot to get a review from CLI folks - @MiYanni if you have any feedback, please let me know and I can address in a follow up |
Without this PR,
dotnet build -bl Program.csis not supported because both args (-blandProgram.cs) are treated as the "project file" argument (that's a pre-existing behavior, even for project-based programs, but for them all unknown arguments are forwarded to msbuild.exe, which we can't do when using msbuild APIs). This PR makes build/restore extract-blarguments just like thedotnet runcommand does.