Fix dotnet package remove command when project is not specified #49314

Copilot · 2025-06-10T17:40:37Z

The new dotnet package remove command was throwing an ArgumentNullException when no project was specified, while the equivalent old dotnet remove package command worked correctly.

Issue

# Not working - throws ArgumentNullException
dotnet package remove System.Text.Json

# Working
dotnet remove package System.Text.Json

# Working 
dotnet package remove System.Text.Json --project MyProject.csproj

Root Cause

The PackageRemoveCommand constructor tried to get the project path from two sources:

PackageCommandParser.ProjectOption (--project flag)
RemoveCommandParser.ProjectArgument (from old command structure)

When using the new syntax without --project, both sources returned null because the new command doesn't go through the old remove command parser that has a default value.

Solution

Modified the constructor to default to Environment.CurrentDirectory when both sources are null, matching the expected behavior and consistency with other dotnet commands.

Changes:

PackageRemoveCommand.cs: Replace ArgumentNullException with default to current directory (1 line changed)
GivenDotnetPackageRemove.cs: Add comprehensive test coverage for the new command syntax

The fix is minimal and surgical, maintaining all existing functionality while enabling the expected behavior when no project is specified.

Fixes #49313.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

8xbvsblobprodcus382.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)
bcnvsblobprodcus378.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)
i1qvsblobprodcus353.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)
l49vsblobprodcus358.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)
mfjvsblobprodcus373.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)
s4uvsblobprodcus326.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)
x3yvsblobprodcus370.vsblob.vsassets.io
- Triggering command: /home/REDACTED/work/sdk/sdk/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/sdk/sdk/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/sdk/sdk/artifacts/toolset/10.0.0-beta.25304.106.txt (dns block)
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetRemovePackage --verbosity normal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

marcpopMSFT · 2025-06-18T22:39:31Z

@copilot the new test you added is failing because it uses the full path of the project and the test expects a partial. Can you fix the test? Since the path is going to be different on each OS, what is the best fix? Is it sufficient to check everything before the project name?

marcpopMSFT · 2025-06-23T23:42:38Z

@copilot the new test you added is failing because it uses the full path of the project and the test expects a partial. Can you fix the test? Since the path is going to be different on each OS, what is the best fix? Is it sufficient to check everything before the project name?

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot · 2025-06-23T23:48:53Z

@copilot the new test you added is failing because it uses the full path of the project and the test expects a partial. Can you fix the test? Since the path is going to be different on each OS, what i...

Fixed the test expectation to use the full project path format. The test now expects projectDirectory + Path.DirectorySeparatorChar + "TestAppSimple.csproj" which matches the actual output when the command defaults to the current directory. This follows the same pattern used in the existing GivenDotnetRemovePackage.cs test. Fixed in commit 7fc954b.

@copilot the new test you added is failing because it uses the full path of the project and the test expects a partial. Can you fix the test? Since the path is going to be different on each OS, what i...

Fixed the test expectation to use the full project path format. The test now expects projectDirectory + Path.DirectorySeparatorChar + "TestAppSimple.csproj" which matches the actual output when the command defaults to the current directory. This follows the same pattern used in the existing GivenDotnetRemovePackage.cs test. Fixed in commit 7fc954b.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

7tjvsblobprodcus341.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
c78vsblobprodcus322.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
d0svsblobprodcus381.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
l49vsblobprodcus358.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
lylvsblobprodcus31.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
uy6vsblobprodcus34.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)
vb4vsblobprodcus33.vsblob.vsassets.io
- Triggering command: dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter GivenDotnetPackageRemove.WhenPackageIsRemovedWithoutProjectArgument --verbosity normal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

MiYanni · 2025-06-25T01:37:35Z

src/Cli/dotnet/Commands/Package/Remove/PackageRemoveCommand.cs

@@ -25,7 +25,7 @@ public PackageRemoveCommand(
        _arguments = parseResult.GetValue(PackageRemoveCommandParser.CmdPackageArgument).ToList().AsReadOnly();
        if (_fileOrDirectory == null)
        {
-            throw new ArgumentNullException(nameof(_fileOrDirectory));
+            _fileOrDirectory = Environment.CurrentDirectory;


I'm not sure if this makes sense. But I don't know the code well enough to evaluate that.

@MiYanni I tested locally and it appears to work:
(dogfood) PS C:\test\repro> dotnet package remove System.Text.json
info : Removing PackageReference for package 'System.Text.json' from project 'C:\test\repro\repro.csproj'.

If I test the case of there is no .csproj, the error is good to:
(dogfood) PS C:\test\repro\obj> dotnet package remove System.Text.json
Could not find any project in C:\test\repro\obj.

Frulfump · 2025-07-16T07:57:46Z

test/dotnet.Tests/CommandTests/Package/Remove/GivenDotnetPackageRemove.cs

+                .Fail();
+        }
+    }
+}


Missing final new line. According to the .editorconfig in the root of the repo

[*] insert_final_newline = true

sdk/.editorconfig

Line 10 in 806e650

insert_final_newline = true

And no later rule overrides it to false and I found no .editorconfig closer to the source.

I think it would be a good idea to ask Copilot to run dotnet format on the code it produces to make sure it matches the repos established rules (at least when it's creating completely new files (otherwise dotnet format could cause noise)).

jjonescz · 2025-07-16T10:47:58Z

src/Cli/dotnet/Commands/Package/Remove/PackageRemoveCommand.cs

@@ -25,7 +25,7 @@ public PackageRemoveCommand(
        _arguments = parseResult.GetValue(PackageRemoveCommandParser.CmdPackageArgument).ToList().AsReadOnly();
        if (_fileOrDirectory == null)
        {
-            throw new ArgumentNullException(nameof(_fileOrDirectory));
+            _fileOrDirectory = Environment.CurrentDirectory;


fwiw, my PR #49635 will fix this issue as well

Were you going to add a test for this scenario? Feel free to copy the ones below in but I don't see one in your PR that fixes this. Looks like you do default to CurrentDirectory in the case of both a file and project option are missing. I'll close this PR in favor of yours.

I will copy the tests from here, thanks.

marcpopMSFT · 2025-07-16T21:07:50Z

fixed by jjonesz change

Copilot AI assigned Copilot and marcpopMSFT Jun 10, 2025

Copilot started work on behalf of marcpopMSFT June 10, 2025 17:40 View session

Copilot AI changed the title ~~[WIP] dotnet package remove throws an error if the project is not specified~~ Fix dotnet package remove command when project is not specified Jun 10, 2025

Copilot AI requested a review from marcpopMSFT June 10, 2025 17:52

Copilot finished work on behalf of marcpopMSFT June 10, 2025 17:52

This was referenced Jun 10, 2025

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

dotnet-watch tests failing #40006

Open

marcpopMSFT approved these changes Jun 10, 2025

View reviewed changes

marcpopMSFT force-pushed the copilot/fix-49313 branch from f08dad9 to 9d8a0c9 Compare June 10, 2025 21:53

marcpopMSFT marked this pull request as ready for review June 10, 2025 21:53

marcpopMSFT force-pushed the copilot/fix-49313 branch 2 times, most recently from 52bd9c3 to c2053ad Compare June 13, 2025 22:36

build-analysis bot mentioned this pull request Jun 17, 2025

Throttling of Docker Downloads dotnet/arcade#15659

Open

3 tasks

Fix dotnet package remove command to default to current directory

2612e77

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

marcpopMSFT force-pushed the copilot/fix-49313 branch from c2053ad to 2612e77 Compare June 17, 2025 18:20

Copilot started work on behalf of marcpopMSFT June 18, 2025 22:39 View session

Copilot AI requested a review from marcpopMSFT June 18, 2025 22:39

Copilot started work on behalf of marcpopMSFT June 23, 2025 23:42 View session

Fix test expectation to use full project path in output message

7fc954b

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot finished work on behalf of marcpopMSFT June 23, 2025 23:49

marcpopMSFT approved these changes Jun 24, 2025

View reviewed changes

marcpopMSFT added the Branch Lockdown label Jun 24, 2025

marcpopMSFT removed the Branch Lockdown label Jun 24, 2025

marcpopMSFT requested a review from MiYanni June 24, 2025 22:24

MiYanni reviewed Jun 25, 2025

View reviewed changes

marcpopMSFT assigned MiYanni Jun 27, 2025

marcpopMSFT approved these changes Jun 27, 2025

View reviewed changes

Frulfump reviewed Jul 16, 2025

View reviewed changes

jjonescz reviewed Jul 16, 2025

View reviewed changes

marcpopMSFT closed this Jul 16, 2025

jjonescz added a commit to jjonescz/dotnet-sdk that referenced this pull request Jul 17, 2025

Add tests from dotnet#49314

d6d0778

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix dotnet package remove command when project is not specified #49314

Fix dotnet package remove command when project is not specified #49314

Copilot AI commented Jun 10, 2025 •

edited

Loading

Uh oh!

marcpopMSFT commented Jun 18, 2025

Uh oh!

marcpopMSFT commented Jun 23, 2025

Uh oh!

Copilot AI commented Jun 23, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

MiYanni Jun 25, 2025

Uh oh!

marcpopMSFT Jun 27, 2025

Uh oh!

Frulfump Jul 16, 2025 •

edited

Loading

Uh oh!

jjonescz Jul 16, 2025

Uh oh!

marcpopMSFT Jul 16, 2025

Uh oh!

jjonescz Jul 17, 2025

Uh oh!

marcpopMSFT commented Jul 16, 2025

Uh oh!

Uh oh!

Fix dotnet package remove command when project is not specified #49314

Fix dotnet package remove command when project is not specified #49314

Conversation

Copilot AI commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Root Cause

Solution

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

marcpopMSFT commented Jun 18, 2025

Uh oh!

marcpopMSFT commented Jun 23, 2025

Uh oh!

Copilot AI commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

MiYanni Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

marcpopMSFT Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Frulfump Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

marcpopMSFT Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

jjonescz Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

marcpopMSFT commented Jul 16, 2025

Uh oh!

Uh oh!

Copilot AI commented Jun 10, 2025 •

edited

Loading

Copilot AI commented Jun 23, 2025 •

edited

Loading

Frulfump Jul 16, 2025 •

edited

Loading