Set runtime config values for path to executing script #49330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR sets runtime configuration values for the path to the executing script and updates tests to verify the new behavior.
- Updated the project file generation to include runtime configuration options for file and directory paths.
- Extended test cases to validate different scenarios including relative paths, paths with spaces, and Unicode characters.
- Added support for configuring standard output encoding in test commands and command implementations.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Added ItemGroup elements for runtime config options and multiple new tests covering various path scenarios. |
| test/Microsoft.NET.TestFramework/Commands/TestCommand.cs | Introduced StandardOutputEncoding property and fluent setter to allow customizing output encoding in tests. |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Updated project file generation to include runtime configuration options for entry point paths. |
| src/Cli/Microsoft.DotNet.Cli.Utils/ICommand.cs | Added interface method for setting standard output encoding. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Command.cs | Implemented StandardOutputEncoding to correctly set the process output encoding. |
| src/Cli/Microsoft.DotNet.Cli.Utils/BuiltInCommand.cs | Introduced a stub for StandardOutputEncoding that currently throws NotImplementedException. |
|
@dotnet/run-file for reviews please :) |
jaredpar
approved these changes
Jun 10, 2025
RikkiGibson
approved these changes
Jun 11, 2025
This was referenced Jun 11, 2025
Open
jjonescz
approved these changes
Jun 11, 2025
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
MiYanni
approved these changes
Jun 11, 2025
|
@marcpopMSFT can you merge this? |
This was referenced Jun 11, 2025
|
AppContext is nicer than environment variables, which could propagate to child processes for which they are not appropriate. |
|
The watch, container, and completion failures are all known. Merging per request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49184
I had to update the test infrastructure slightly to enable one of the tests I added. I did that in the second commit so you can see it separate from the actual implementation.