Allow reading file-based app from stdin #49348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeihanLi
reviewed
Jun 12, 2025
chsienki
approved these changes
Jun 12, 2025
jaredpar
reviewed
Jun 13, 2025
| } | ||
|
|
||
| // If '-' is specified as the input file, read all text from stdin into a temporary file and use that as the entry point. | ||
| entryPointFilePath = Path.GetTempFileName(); |
There was a problem hiding this comment.
On Unix can't assume that only current user has access to this file path. Don't we need to enforce current user permissions?
There was a problem hiding this comment.
Good point. It seems that GetTempFileName uses mkstemps which creates the file with 0600 permissions. I'm not sure if all that is guaranteed, but I'd hope it is, I see GetTempFileName used all over the place without any additional code to enforce the unix mode.
This was referenced Jun 13, 2025
MiYanni
approved these changes
Jun 17, 2025
jaredpar
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49201.