Skip to content

[wasm] Prepare for new boot config schema #49373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Jun 12, 2025

Prerequisite for dotnet/runtime#116300

@maraf maraf added this to the 10.0.1xx milestone Jun 12, 2025
@maraf maraf self-assigned this Jun 12, 2025
@maraf maraf marked this pull request as ready for review June 13, 2025 09:37
@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 09:37
@maraf maraf requested a review from a team as a code owner June 13, 2025 09:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the infrastructure for a new boot configuration schema by updating boot manifest verification in tests and enhancing JSON deserialization logic to support a new resources structure.

  • Updates test verification to include new fields (coreAssembly, corePdb) and remove deprecated ones (jsModuleNative, jsModuleRuntime).
  • Enhances BootJsonData deserialization with a new ResourcesConverter and conversion logic from AssetsData to ResourcesData.
  • Adds new resource properties (jsModuleDiagnostics, wasmSymbols, coreVfs) to support the updated schema.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishIntegrationTestBase.cs Adds verification for new boot manifest fields and removes deprecated module checks.
test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BootJsonData.cs Implements new JSON conversion logic, introduces ResourcesConverter, and extends resource properties to support the new boot config schema.

@maraf
Copy link
Member Author

maraf commented Jun 13, 2025

/ba-g Failure in Microsoft.NET.Build.Tests.dll.6.WorkItemExecution is unrelated

@akoeplinger akoeplinger merged commit a37b351 into dotnet:main Jun 13, 2025
28 of 30 checks passed
@maraf maraf deleted the WasmNewBootSchema branch June 13, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants