Actually mark dnx script as executable #49489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the executable permission for the dnx script by changing the chmod command from 644 to 755.
- Corrects file permissions on non-Windows platforms
- Ensures the dnx script is marked as executable
Comments suppressed due to low confidence (1)
src/Layout/redist/targets/GenerateInstallerLayout.targets:75
- The change from 'chmod 644' to 'chmod 755' correctly updates the script's permissions to be executable. Please confirm that 755 is the desired permission level for your security and execution requirements in your deployment environments.
<Exec Command="chmod 755 "$(RedistInstallerLayoutPath)/dnx"" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
baronfel
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #49461, I used
chmod 644instead ofchmod 755when trying to mark thednxscript as executable. Oops. This should fix that.