Expose public initializer for HttpConnectionOptions #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjqian
approved these changes
May 5, 2025
|
@bjqian could you please also release a version with this change? |
bjqian
added a commit
that referenced
this pull request
May 6, 2025
* Add action for dev (#72) * Add message buffer (#73) * Add message buffer * Some improvement * Improve again * Add client to server stream (#74) * Add client to server stream * increase timeout * Add public initializer to HttpConnectionOptions to allow external instantiation (#76) * hide stateful reconnect, prepare release for 1.0.0-preview.4 (#78) * Hide stateful reconnect options * Add public init for MsgpackTimestamp * Release 1.0.0-preview.4 * Update readme --------- Co-authored-by: Chenyang Liu <zackliu1995@hotmail.com> Co-authored-by: Yannis Alexiou <yannisalexiou@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Summary
This PR adds a
public init()to theHttpConnectionOptionsstruct, enabling external consumers to create and customize instances outside the module.Problem
Currently,
HttpConnectionOptionsis apublic structwith severalpublicproperties, includingaccessTokenFactory. However, it lacks a public initializer, making it impossible to construct an instance from outside the module.This prevents developers from using methods like:
Related Issue
This fix is related to #65 and especially the last comment from @mikheil-natsvlishvili
#65 (comment)
A full explanation of this issue can be found here #77