Skip to content

Fluent2 Editable ComboBox Issues #10470

@robert-abeo

Description

@robert-abeo

Description

The Fluent2 Editable ComboBox has a few issues:

  1. Background doesn't change when editing text (focused)
  2. It ideally needs to have the same border style as TextBox when unfocused. However, this may be a design decision (I disagree with) to keep an editable ComboBox looking more like a traditional ComboBox rather than a TextBox.

This is most noticeable in dark theme.

Reproduction Steps

.NET 9 Fluent theme
ComboBox with IsEditable="True"

Expected behavior

Editable ComboBox should match closely with TextBox styling.

Actual behavior

Unfocused ComboBox (top) is missing the more prominent "underline" bottom border indicating it is a text input.

Image

A focused ComboBox does not change the background when entering text.

Image

... as compared to TextBox

Image

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response

Activity

lindexi

lindexi commented on Feb 19, 2025

@lindexi
Member

Yes, I agree that editable ComboBox should match closely with TextBox styling.

The editing ComboBox in WinUI 3:

added a commit that references this issue on Feb 19, 2025
dipeshmsft

dipeshmsft commented on Apr 25, 2025

@dipeshmsft
Member

I agree that Editable ComboBox should be nearer in style to a TextBox, like in case of focused and selection states.

However that would also mean that we are departing a little from what WinUI does.

Comments ? I will try to discuss this with internal design team and see what opinions they have.

robert-abeo

robert-abeo commented on Apr 25, 2025

@robert-abeo
Author

@dipeshmsft Editable ComboBoxes was a late addition to UWP/WinUI and left a few things to be desired if I recall correctly. WPF was always more functional in this area.

That said, I think you are incorrect. What I'm asking for is exactly what is already done in WinUI. When I edit a combobox in the WinUI3 gallery it is as expected and is designed to look just like a TextBox. (background changes on focus, bottom border it accent color, etc.)

Image

moved this to 🏗 In Progress in WPF Fluent Themingon May 21, 2025
moved this from 🏗 In Progress to ☑ Done in WPF Fluent Themingon Jun 3, 2025
locked and limited conversation to collaborators on Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    ☑ Done

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @lindexi@dipeshmsft@robert-abeo

      Issue actions

        Fluent2 Editable ComboBox Issues · Issue #10470 · dotnet/wpf