Use explicit immutable Actions, move permissions to top of workflow, add missing test file, add test workflow #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the workflow configuration by moving the permissions configuration to the top level and using explicit immutable action versions.
- Reorders the YAML file to declare global permissions before the jobs.
- Updates GitHub Actions versions (checkout from v3 to 4.2.2 and codeql-action/upload-sarif from v3 to 3.28.15).
aegilops
changed the title
aegilops
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR improves the repository’s workflow security by using explicit immutable action versions and moving permissions to the top of workflows, while also adding a new test workflow and a missing test file.
- Added a new test workflow to run npm tests.
- Updated workflow configurations in scorecard, publish, and eslint to use explicit action versions and defined permissions.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Added a new test workflow file with explicit action versions and permissions at the top. |
| .github/workflows/scorecard.yml | Updated action version references for checkout, upload-artifact, and upload-sarif steps. |
| .github/workflows/publish.yml | Moved permissions inside the publish job and updated action versions for consistency. |
| .github/workflows/eslint.yml | Added a permissions block and updated checkout and upload-sarif action versions. |
Files not reviewed (1)
- testFile.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.