-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JS: Improve Express middleware taint tracking #19784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
67aac7a
JS: add test cases for middleware property assignment tracking
Napalys da21a06
JS: add `_parsedUrl` as remote input source
Napalys 060b98d
JS: enchance middleware taint tracking via local source
Napalys 7252874
JS: add change note
Napalys c1b2fd8
Update javascript/ql/lib/semmle/javascript/frameworks/Express.qll
Napalys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
javascript/ql/lib/change-notes/2025-06-16-middleware-express.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * Improved data flow tracking through middleware to handle default value and similar patterns. | ||
| * Added `req._parsedUrl` as a remote input source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
javascript/ql/test/query-tests/Security/CWE-918/serverSide2.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| const express = require('express'); | ||
| const axios = require('axios'); | ||
| const qs = require('qs'); | ||
|
|
||
| const app = express(); | ||
| const PORT = 3000; | ||
|
|
||
| app.use((req, res, next) => { | ||
| req.parsedQueryFromParsedUrl = qs.parse(req._parsedUrl.query); // $Source[js/request-forgery] | ||
| req.parsedQuery.url = req.url || {}; // $Source[js/request-forgery] | ||
| req.SomeObject.url = req.url; // $Source[js/request-forgery] | ||
| next(); | ||
| }); | ||
|
|
||
| app.get('/proxy', async (req, res) => { | ||
| const targetUrl = req.parsedQuery.url; | ||
| const response = await axios.get(targetUrl); // $Alert[js/request-forgery] | ||
|
|
||
| const targetUrl1 = req.parsedQueryFromParsedUrl.url; | ||
| const response1 = await axios.get(targetUrl1); // $Alert[js/request-forgery] | ||
|
|
||
| const targetUrl2 = req.url || {}; // $Source[js/request-forgery] | ||
| const response2 = await axios.get(targetUrl2); // $Alert[js/request-forgery] | ||
|
|
||
| const targetUrl3 = req.SomeObject.url || {}; | ||
| const response3 = await axios.get(targetUrl3); // $Alert[js/request-forgery] | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.