Cron error recovery #544
Merged
Cron error recovery #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if cron is running and the database connection goes away, it's likely that cron will bring down the entire worker instance from the inside on the next minute tickover.
This PR changes this, cron now handles its own errors via exponential backoff. This does mean that if there are bugs in cron then those errors will be logged but won't cause the system to exit, but it's necessary to be resilient to connection failure.
In future we should filter errors on expected connection error codes but enumerating those is quite tough:
57P03for recovery,53300for too many connections, etc)For now, just retrying infinitely seems like the best approach.