Skip to content

Add support for encrypted query parameters #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fijxu
Copy link
Member

@Fijxu Fijxu commented Jul 7, 2025

May close #2142

Encrypts sensitive query parameters that should be hidden to users like ip and pot using the hmac_key config option.

Taken from iv-org/invidious-companion#65

There is some problems with this current implementation:

Since Invidious companion will be become the official way to fetch youtube videos and videoplayback proxying, this may not be very useful on the future since companion is already able to encrypt the ip and pot query parameters, but will work for old setups that are still using inv_sig_helper for whatever reason (low memory capacity for example, since Invidious companion uses way more memory than inv_sig_helper)

@Fijxu Fijxu requested review from SamantazFox and unixfox as code owners July 7, 2025 00:56
@Fijxu
Copy link
Member Author

Fijxu commented Jul 7, 2025

Oops, I didn't know that require "uri/params/serializable" was unsupported on Crystal <=1.13.3 (https://github.com/iv-org/invidious/actions/runs/16105127771/job/45439447127?pr=5381#step:7:11). I guess I'll do it another way then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Server ip address leaked when behind a proxy.
1 participant