Skip to content

Remove not supported attribute tags from description. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Bashev
Copy link

@Bashev Bashev commented Sep 13, 2023

…r empty description.

  1. Meta not support attributes in the allowed tags used in the description (rich_description), but sometimes in they can be added from wyswyg editor. We just remove them.

  2. Added fallback if product description and short_description are both missing, use product name instead of sending empty string.

Description (*)

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento-commerce/facebook-for-magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@zlik
Copy link
Contributor

zlik commented Sep 1, 2024

@Bashev, please correct me if I'm wrong but don't think there's any harm in sending those extra attributes. Also, if a description is empty, using name as description provides no incremental gain to catalog quality. If you need this as a fallback, feel free to extend the functionality in your custom build. Closing the PR for now but feel free to submit a new one if you disagree or if you have more thoughts / ideas. Thank you!

@zlik zlik closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants