Skip to content

Do not change preferences for magento default types #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ihor-sviziev
Copy link

Description (*)

I noticed that meta extension has adding type preferences for some magento-core classes / interfaces, which are declared in Magento itself. And I don't see the reasoning behind it.
This might cause some conflicts with modules that replaces type to their own.

In magento core it's already declared in https://github.com/magento/magento2/blob/2.4/app/etc/di.xml#L124 and in https://github.com/magento/magento2/blob/2.4/app/code/Magento/Backend/etc/di.xml#L9 (2nd one suppose to be removed)

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento-commerce/facebook-for-magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ihor-sviziev
Copy link
Author

@zlik pls review

@zlik
Copy link
Contributor

zlik commented Oct 30, 2023

Merged in private repo, will release in 1.2.2. Thanks, @ihor-sviziev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants