Skip to content

Add store id to order item #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ihor-sviziev
Copy link

@ihor-sviziev ihor-sviziev commented Oct 16, 2023

Description (*)

We noticed that the store ID field needs to be filled correctly for the order item objects. As a result, some of our integrations with Magento are having issues processing orders that the Meta extension pulls.
This change fixes this misbehavior. Unfortunately, it won't fix the previous data, but will help for newly synced orders.

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento-commerce/facebook-for-magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ihor-sviziev ihor-sviziev marked this pull request as ready for review October 16, 2023 11:15
@ihor-sviziev
Copy link
Author

@zlik pls review

@zlik
Copy link
Contributor

zlik commented Oct 24, 2023

Merged through a private repo (don't have write permission to this one), thank you for your contribution @ihor-sviziev!

@zlik zlik closed this Oct 24, 2023
@ihor-sviziev ihor-sviziev deleted the patch-3 branch October 24, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants