-
Notifications
You must be signed in to change notification settings - Fork 332
[infra] Use Artifacts Output layout #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[infra] Use Artifacts Output layout #2816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
- Coverage 73.91% 69.70% -4.21%
==========================================
Files 267 394 +127
Lines 9615 15978 +6363
==========================================
+ Hits 7107 11138 +4031
- Misses 2508 4840 +2332 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the Artifacts Output layout to simplify locating build outputs and de-nest the structure of ZIP files for package uploads. Key changes include updating test projects to determine paths via assembly metadata, revising build and project files to use a consistent Import strategy, and modifying GitHub Actions workflows and scripts to reflect the new artifacts output structure.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/TestApplication/TestApplicationFactory.cs | Uses AssemblyMetadataAttribute to resolve RouteTestsPath and update ContentRootPath accordingly. |
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTestFixture.cs | Retrieves RouteTestsPath from assembly metadata and updates the README file generation logic. |
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/OpenTelemetry.Instrumentation.AspNetCore.Tests.csproj | Adds an AssemblyMetadata element for the RouteTestsPath. |
test/Directory.Build.props, src/Directory.Build.props, examples/Directory.Build.props | Updates Import statements to utilize Path.Combine for more robust file referencing. |
build/scripts/test-aot-compatibility.ps1 | Adjusts the test app’s push-location to use the new artifacts publish path. |
build/Common.prod.props | Removes the PackageOutputPath element to align with the Artifacts Output layout change. |
Directory.Build.props (root) | Introduces properties for ArtifactsPath and the UseArtifactsOutput flag. |
.github/workflows/publish-packages.yml, .github/workflows/Component.BuildTest.yml | Updates package paths and nuget push commands to reference the new artifacts layout. |
Comments suppressed due to low confidence (4)
build/Common.prod.props:15
- The removal of the PackageOutputPath element alters the package output location. Please verify that this change aligns with the intended artifacts output layout and that downstream processes respect this new location.
<NoWarn>$(NoWarn);1573;1712</NoWarn>
build/scripts/test-aot-compatibility.ps1:29
- [nitpick] Consider adding or updating tests to verify that the updated artifacts output path is correctly generated and used during the AOT compatibility test.
Push-Location $rootDirectory/artifacts/publish/OpenTelemetry.AotCompatibility.TestApp/release_$targetNetFramework
.github/workflows/publish-packages.yml:89
- [nitpick] Confirm that the updated relative path for package artifacts works consistently across all targeted operating systems in the CI environment.
path: ./artifacts/package/release
.github/workflows/Component.BuildTest.yml:171
- [nitpick] Ensure that changing the artifact path in this workflow does not affect other build dependencies and is verified across different OS runners.
path: ./artifacts/package/release
5a056ce
to
f19539d
Compare
Use Artifacts Output layout to make build output easy to locate. Relates to open-telemetry/opentelemetry-dotnet#6256.
77e7ab3
to
fd6d107
Compare
Relates to open-telemetry/opentelemetry-dotnet#6256.
Changes
Use Artifacts Output layout to make build output easy to locate.
This has the additional effect of de-nesting the structure of the ZIP files containing the packages that are uploaded to GitHub Actions artifacts.
Essentially a copy of open-telemetry/opentelemetry-dotnet#6301.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes