[Resources.ProcessRuntime] Allow preview versions #2823
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:resources.processruntime
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test assertion for ProcessRuntime attributes to support preview and release candidate .NET versions.
- Updated the regex in ProcessRuntimeDetectorTests.cs to correctly match preview and RC versions.
- Ensured compatibility with the test for .NET version string formatting.
test/OpenTelemetry.Resources.ProcessRuntime.Tests/ProcessRuntimeDetectorTests.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
==========================================
+ Coverage 73.91% 83.33% +9.41%
==========================================
Files 267 4 -263
Lines 9615 60 -9555
==========================================
- Hits 7107 50 -7057
+ Misses 2508 10 -2498
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
martincostello
force-pushed
the
allow-previews
branch
from
0482831 to
aa00620
Compare
TimothyMothra
approved these changes
Jun 17, 2025
Update assertion to not fail if a preview or release candidate version of .NET is being used.
martincostello
force-pushed
the
allow-previews
branch
from
aa00620 to
42b226e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update assertion to not fail if a preview or release candidate version of .NET is being used.
See #2822.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes