-
Notifications
You must be signed in to change notification settings - Fork 332
[Infra] Update Dockerfiles with dependabot #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Infra] Update Dockerfiles with dependabot #2838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dependabot configuration to ensure that SDK versions in Dockerfiles remain in sync with the .NET SDK specified in global.json by scheduling weekly updates for Docker-based test directories.
- Added weekly dependabot schedules for three test directories using docker package-ecosystem.
- The updated configuration supports regular dependency updates for tests involving Cassandra, ConfluentKafka, and StackExchangeRedis.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 73.91% 69.80% -4.12%
==========================================
Files 267 394 +127
Lines 9615 15978 +6363
==========================================
+ Hits 7107 11153 +4046
- Misses 2508 4825 +2317 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
.github/dependabot.yml
Outdated
@@ -6,6 +6,42 @@ updates: | |||
interval: "daily" | |||
labels: | |||
- "infra" | |||
- package-ecosystem: "docker" | |||
directory: "test/OpenTelemetry.Instrumentation.Cassandra.Tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, would it make sense to scan the entire "test/*" directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I genuinely don't know if it recurses or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it can :)
I think we should give this a try.
# Specify all directories from the current layer and below recursively,
# using globstar, for locations of manifest files
version: 2
updates:
- package-ecosystem: "composer"
directories:
- "**/*"
schedule:
interval: "weekly"
Update dependabot configuration to keep the SDK versions in the Dockerfiles up-to-date on a weekly basis to match the .NET SDK in `global.json`.
Only apply patches.
Use a glob to recurse for Dockerfiles.
2a6e959
to
6ae267f
Compare
Changes
Update dependabot configuration to keep the SDK versions in the Dockerfiles up-to-date on a weekly basis to match the .NET SDK in
global.json
.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes