[SqlClient] Unify .NET/.NET Framework tests #2850
Open
+650
−478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.sqlclient
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2850 +/- ##
===========================================
+ Coverage 73.91% 88.26% +14.34%
===========================================
Files 267 9 -258
Lines 9615 460 -9155
===========================================
- Hits 7107 406 -6701
+ Misses 2508 54 -2454
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
martincostello
approved these changes
Jun 18, 2025
| @@ -27,22 +27,19 @@ public SqlClientIntegrationTests(SqlClientIntegrationTestsFixture fixture) | |||
| [InlineData(CommandType.Text, "select 1/1")] | |||
| [InlineData(CommandType.Text, "select 1/1", true, "select ?/?")] | |||
| [InlineData(CommandType.Text, "select 1/0", false, null, true)] | |||
| [InlineData(CommandType.Text, "select 1/0", false, null, true, false, false)] | |||
| [InlineData(CommandType.Text, "select 1/0", false, null, true, true, false)] | |||
| [InlineData(CommandType.Text, "select 1/0", false, null, true, true)] | |||
There was a problem hiding this comment.
Do you get the same failure locally as I get as fixed in #2826?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR bringing some sanity to SqlClient tests. The main purpose is to leverage the same test suite introduced in #2798 for .NET Framework.