[Prototype] attribute: add complex value types #6809
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/go-maintainers, do you think that there anything more that I should add/check in order to validate the open-telemetry/opentelemetry-specification#4485? |
pellared
changed the title
pellared
requested review from
MrAlias,
XSAM,
dashpole and
dmathieu
as code owners
pellared
changed the title
|
SIG meeting: |
pellared
changed the title
pellared
commented
May 27, 2025
| } | ||
|
|
||
| // MapValue creates a MAP Value. | ||
| // v is sorted by key. |
There was a problem hiding this comment.
We should also deduplicate keys, but this is an implementation detail not relevant for the prototype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for open-telemetry/opentelemetry-specification#4485
This PR is to validate that it is possible to extend attributes with complex attributes without making breaking changes and making sure that
Valueis still comparable.It does not implement everything. I was just focused how we are able to handle the following new attribute value types in a backwards compatible way:
This PR does not update the code dependent on attributes package. Exporters do not export complex attributes and the Logs API do not use this package. Nothing prevents doing it and I think this is not necessary to validate the OTEP.