-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor(log/logtest): update AssertEqual to accept TestingT for benchmark support #6908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6908 +/- ##
=======================================
+ Coverage 82.3% 82.9% +0.6%
=======================================
Files 263 261 -2
Lines 24476 24259 -217
=======================================
- Hits 20151 20122 -29
+ Misses 3942 3760 -182
+ Partials 383 377 -6
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping changelog, as this module isn't released yet.
I am not sure we are inn favor of this change. Please see the conversation here: See: #6662 (comment) My initial proposal was to expose // TestingT reports failure messages.
// *testing.T, *testing.B, *testing.F implement this interface.
type TestingT interface {
Errorf(format string, args ...any)
} What are the benefits of using |
I also agree with exposing the |
…nd update usage in tests
This might just be a minor optimization, a non-functional change. Perhaps it can skip the
CHANGELOG
.