Add ONC/Sun RPC model and NFS system metrics #2287

johnleslie · 2025-05-19T23:19:31Z

Changes

Add ONC/Sun RPC model and NFS system metrics

Merge requirement checklist

CONTRIBUTING.md guidelines followed.
Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with [chore]
[N/A] schema-next.yaml updated with changes to existing conventions.
- Added to rpc/registry.yaml:rpc.* but did not change any existing elements

…RPC to registry Initial metrics based on Linux kernel, but mostly overlap with other OS' including FreeBSD

…nventions#2287

…and "make generate"

…unt for NFSv4+ operations. remove unused rpc.onc_rpc

lmolkova · 2025-06-05T19:35:12Z

@johnleslie thanks for the contribution!
JFYI: we're starting RPC stabilization project open-telemetry/community#2684, which is likely to result in significant refactoring of existing RPC conventions.

Please check out the blog post on the scope and details

braydonk

I think the file permission changed on model/system/metrics.yaml and I think it was potentially unintentional. Should that be reverted?

model/system/metrics.yaml

johnleslie · 2025-06-06T20:38:08Z

I think the file permission changed on model/system/metrics.yaml and I think it was potentially unintentional. Should that be reverted?

fixed

johnleslie · 2025-09-04T20:47:31Z

@jsuereth @braydonk @lmolkova looks like all comments are resolved -- can you merge?

braydonk

Running make registry-generation and applying my suggestion should fix the CI failures.

model/rpc/registry.yaml

Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>

…isses/metric.nfs.server.repcache.nocache as nfs.server.repcache.requests with an attribute

suggested changes from PR review

Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>

All linked comments are resolved. Dismissing

…(and 2 followup PRs)

johnleslie added 6 commits May 9, 2025 17:45

add ONC/Sun RPC: rpc.system.onc_rpc / rpc.onc

7fd1f49

add NFS client and server metrics: system.nfs / system.nfsd; add ONC …

6fdc64c

…RPC to registry Initial metrics based on Linux kernel, but mostly overlap with other OS' including FreeBSD

Merge remote-tracking branch 'upstream/main' into model-nfs

82d21fb

fixup

a89d509

Merge remote-tracking branch 'upstream/main' into model-nfs

c900597

bug fix

ecef4c8

johnleslie added a commit to johnleslie/opentelemetry-collector-contrib that referenced this pull request May 20, 2025

add all metrics from semantic-conventions: open-telemetry/semantic-co…

40a6ba3

…nventions#2287

johnleslie added a commit to johnleslie/opentelemetry-collector-contrib that referenced this pull request May 20, 2025

populate metadata.yaml from open-telemetry/semantic-conventions#2287 …

52a0fb0

…and "make generate"

johnleslie added 10 commits May 27, 2025 19:18

s/{rpc}/{request}/ to match convention

b73206d

Merge remote-tracking branch 'upstream/main' into model-nfs

3fef223

add metric.system.nfs.operation.count/metric.system.nfsd.operation.co…

7df74e8

…unt for NFSv4+ operations. remove unused rpc.onc_rpc

Merge remote-tracking branch 'upstream/main' into model-nfs

4a3f2fe

missing space

318c371

operations are nfs-specific

b83c864

s/int/string/

bfe78c3

Merge remote-tracking branch 'upstream/main' into model-nfs

4154e37

add rpc.nfs.operation.name

9a089e3

remove onc_rpc

609dcc0

johnleslie marked this pull request as ready for review June 4, 2025 17:26

johnleslie requested review from a team as code owners June 4, 2025 17:26

braydonk reviewed Jun 6, 2025

View reviewed changes

model/system/metrics.yaml Outdated Show resolved Hide resolved

model/system/metrics.yaml Outdated Show resolved Hide resolved

johnleslie added 2 commits June 6, 2025 20:37

Merge remote-tracking branch 'upstream/main' into model-nfs

0ddfce3

fix perms

bf01119

johnleslie added 3 commits June 6, 2025 20:54

add nfs/metrics.yaml: nfs client and server metrics

e0cac00

add NFS

a0c6403

add template nfs-metrics.md per CONTRIBUTING.md

dcbc424

johnleslie added 3 commits September 2, 2025 20:04

update brief

2dd6997

update brief; update unit

ba2afb6

clarify brief for nfs.server.repcache.nocache

40e93e7

braydonk reviewed Sep 4, 2025

View reviewed changes

model/rpc/registry.yaml Outdated Show resolved Hide resolved

johnleslie and others added 5 commits September 4, 2025 16:21

Update model/rpc/registry.yaml

c3fd7d6

Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>

make registry-generation

73332f8

Merge remote-tracking branch 'upstream/main' into model-nfs

f59c32f

Merge remote-tracking branch 'origin/model-nfs' into model-nfs

848d1ba

refactor metric.nfs.server.repcache.hits/metric.nfs.server.repcache.m…

23028ce

…isses/metric.nfs.server.repcache.nocache as nfs.server.repcache.requests with an attribute

johnleslie force-pushed the model-nfs branch from 7931fe3 to 23028ce Compare September 5, 2025 00:22

johnleslie and others added 6 commits September 5, 2025 00:23

make registry-generation

4fb4ea1

rename and regenerate tables, remove dead md snippets

69e6acf

display name and acronyms

80ae70b

more acronyms

05d4dcf

more cleanup

d43bd94

Merge pull request #1 from lmolkova/nfs-metrics

9e77937

suggested changes from PR review

johnleslie requested a review from a team as a code owner September 11, 2025 16:31

yamllint the repo

84ee66c

johnleslie requested review from a team as code owners September 12, 2025 22:40

add trailing '.'

7ca5c61

lmolkova approved these changes Sep 14, 2025

View reviewed changes

lmolkova moved this from Blocked to Ready to be Merged in Semantic Conventions Triage Sep 14, 2025

update issue templates

2542828

Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>

joaopgrassi added this pull request to the merge queue Sep 15, 2025

Merged via the queue into open-telemetry:main with commit 5ee549b Sep 15, 2025
24 checks passed

johnleslie added a commit to johnleslie/opentelemetry-collector-contrib that referenced this pull request Oct 2, 2025

revamp metadata.yaml based on open-telemetry/semantic-conventions#2287 …

3929435

…(and 2 followup PRs)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ONC/Sun RPC model and NFS system metrics #2287

Add ONC/Sun RPC model and NFS system metrics #2287

Uh oh!

johnleslie commented May 19, 2025 •

edited

Loading

Uh oh!

lmolkova commented Jun 5, 2025

Uh oh!

braydonk left a comment

Uh oh!

Uh oh!

Uh oh!

johnleslie commented Jun 6, 2025

Uh oh!

johnleslie commented Sep 4, 2025

Uh oh!

braydonk left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add ONC/Sun RPC model and NFS system metrics #2287

Add ONC/Sun RPC model and NFS system metrics #2287

Uh oh!

Conversation

johnleslie commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Merge requirement checklist

Uh oh!

lmolkova commented Jun 5, 2025

Uh oh!

braydonk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

johnleslie commented Jun 6, 2025

Uh oh!

johnleslie commented Sep 4, 2025

Uh oh!

braydonk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnleslie commented May 19, 2025 •

edited

Loading