Enhance type annotations and error handling in Android build script #135556
Conversation
- Added type hints for function parameters and return types to improve code clarity and type checking. - Enhanced error handling in subprocess calls to provide clearer error messages and prevent crashes. - Updated the `parse_args` function to validate paths for site-packages and working directories. - Improved the `list_devices` and `find_device` functions to handle exceptions and provide informative error messages. - Refactored several functions to use more specific types from the `typing` module for better type safety.
bionicbeaverlinux2
requested review from
mhsmith and
freakboy3742
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I'm not sure why you've closed, this, but here's some feedback anyway:
Unless the hints are actually being checked, I don't think this is worth the noise. And if they're not being checked, they'll inevitably become wrong in the future, which would be worse than having no hints at all.
Some of this is useful, e.g better error messages in except Exception as e:
sys.exit(f"Failed to determine host from sysconfig files: {e}")And some of the exception handlers are redundant, e.g. catching
This is also redundant, as the paths are already validated in testbed/app/build.gradle.kts. And in the process you removed the use of |
|
Right thank you. |
parse_argsfunction to validate paths for site-packages and working directories.list_devicesandfind_devicefunctions to handle exceptions and provide informative error messages.typingmodule for better type safety.