Fix reportImplicitOverride error from _type_checker_internals.pyi (pyright)
#14255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geson-anko
changed the title
reportImplicitOverride error from _type_checker_internals.pyi (pyright)reportImplicitOverride error from _type_checker_internals.pyi (pyright)
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Thank you. However, we already discussed this change in #14115. I don't think making this change to either typeshed directly or to pyright's vendored version of typeshed is the solution to this problem. However, the good news is that it looks like a fix for the issue has already landed on pyright's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
I've fixed unintended error
reportImplicitOverrideof pyright from_type_checker_internals.pyi.See original issue: microsoft/pyright#10484