attempt to improve sched.scheduler.enterabs/sched.scheduler.enter

[cj81499]

These changes are wrong and should not be merged. I'm hoping there might be a way to improve the type hints here (because I often get this wrong). Unfortunately, I'm not aware of one :(

[cj81499]

These changes are wrong. I'd like to be able to say something like the following, but (afaik) Python's type system doesn't support it¹ :(

Suggested change

	def enterabs(self, time: float, priority: object, action: Callable[PS, R], *args: PS.args, **kwargs: PS.kwargs) -> Event: ...
	def enter(self, delay: float, priority: object, action: Callable[PS, R], *args: PS.args, **kwargs: PS.kwargs) -> Event: ...
	def enterabs(self, time: float, priority: Any, action: Callable[PS, R], argument: PS.args, kwargs: PS.kwargs) -> Event: ...
	def enter(self, delay: float, priority: Any, action: Callable[PS, R], argument: PS.args, kwargs: PS.kwargs) -> Event: ...

Footnotes

1. or at least, type checkers do not support it ↩

[cj81499]

my idea here is essentially to reinvent the wheel of Callable so that we can preserve some info about both positional and keyword argument types. The type system isn't perfect here, since there (afiak) no info to preserve perfect info about positional only args, positional/kw args, and kw-only args other than ParamSpec, which isn't usable in this context (b/c enter takes argument/kwargs, not *args/**kwargs).

I expect that V will be pretty poor at preserving this info for Callables with many different kw arg types, but... maybe this is something?

[cj81499]

Nevermind.

I tried this out using mypy with --custom-typeshed-dir and it doesn't work :(

Even after fiddling with it a bit, the best I could do was:

demo.py:17: error: Argument 3 to "enter" of "scheduler" has incompatible type "Callable[[], None]"; expected "_MyCallable[*tuple[Never, ...], Never, object]"  [arg-type]

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉