Skip to content

Add Bugsink as a "consumer" to debug-id.md #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

vanschelven
Copy link
Contributor

No description provided.

@vanschelven
Copy link
Contributor Author

I did read the contributing guidelines, and realize that those state that to contribute, I'd need to join the TC;

happy to do that if indeed required; for now I'm just leaving this here "out of order", as I imagine that the single act of documenting the existence of a consumer of debug IDs may not have such strict requirements, or otherwise, someone who is on the TC is willing to "sponsor" this PR.

@lforst
Copy link
Member

lforst commented Apr 16, 2025

I am technically the champion of this proposal, and I welcome anybody in support of it, but I think I have a bit of a conflict of interest here.

I would personally be okay with adding Bugsink as a consumer if you can guarantee that your backend does not simply re-use Sentry code (i.e. symbolicator or the Sentry backend). All of the tools in the blog post you linked are Sentry tools, and unless your backend has a different implementation, it would feel wrong to list Bugsink, as it would just be all the same tooling with a different name, which would be dishonest to anybody reading and signing off on the proposal.

Since I have a conflict of interest, I will defer to other TC39 members for this one.

@vanschelven
Copy link
Contributor Author

vanschelven commented Apr 16, 2025

simply re-use Sentry code [..] symbolicator [..] Sentry backend [..] Sentry tools

I get the point; let's leave the weighing of that point to other TC39 members. In the meantime I'll answer.

  • for the injection of Debug IDs, Bugsink relies entirely on other (Sentry) tools, in particular on sentry-cli
  • for the consumption of the Debug IDs, there is no external dependency at all, Bugsink simply has its own implementation of this functionality. Given the header "Consumers/Debuggers" I'd argue this is the relevant fact 😄

for completeness: for sourcemaps parsing, Bugsink does not rely on symbolicator, although it currently does rely on another Open Source library

@lforst
Copy link
Member

lforst commented Apr 16, 2025

I see! Considering that the Bugsink backend has a different implementation as consumer I am fine with adding it to the list :)

@nicolo-ribaudo
Copy link
Member

I was also a little bit conflicted about this, for a different reason: I don't want proposals to just become a list of "advertisement" for products. It's good however to show that there are multiple real-world use cases for the proposal, and that it's not just Sentry doing their own thing.

That said, a list containing two links is far from being what I consider problematic :P

I'll merge this pr as @lforst approved it. Luca, I'll give you write access to the repo so that you can merge PRs related to DebugID.

@nicolo-ribaudo nicolo-ribaudo merged commit 8cc45d2 into tc39:main May 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants