Skip to content

Decode target ID from location.hash rather than using it as an ID selector #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Decode target ID from location.hash rather than using it as an ID selector #646

merged 2 commits into from
Apr 30, 2025

Conversation

gibson042
Copy link
Contributor

Ref #645

Code hygiene—there's no guarantee that location.hash is a valid CSS selector, or that it actually corresponds with an element.

michaelficarra
michaelficarra approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did we start trying to make ecmarkup code good?

@bakkot bakkot merged commit b894f22 into tc39:main Apr 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra

@ctcpip ctcpip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gibson042 @michaelficarra @ctcpip @bakkot