-
Notifications
You must be signed in to change notification settings - Fork 182
[CI] Centralize clang-format install to dependencies-dev #2543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I say better to stick to the same version everywhere, to avoid surprises. |
I agree. I just had the case that some |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
/intelci: run |
/intelci: run |
/intelci: run |
1 similar comment
/intelci: run |
Description
Clang-format is a requirement for building daal4py and therefore sklearnex (https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/INSTALL.md#build-from-sources ), but as noted by @ahuber21 it isn't in our
dependencies-dev
list, which makes seamless environment creation to builds annoying.Clang-format is available via PyPI (https://pypi.org/project/clang-format/) and should probably be taken from there instead. We currently already acquire it for use in .pre-commit-config via PyPI.
One question to reviewers is whether we go always with the most modern version, or if we should set it to what is used in the pre-commit hook.
All other extractions (via conda etc) are removed from the non-CondaRecipes CI jobs. This will require a private CI run to verify impact there.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance