Skip to content

[CI] Centralize clang-format install to dependencies-dev #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Jun 13, 2025

Description

Clang-format is a requirement for building daal4py and therefore sklearnex (https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/INSTALL.md#build-from-sources ), but as noted by @ahuber21 it isn't in our dependencies-dev list, which makes seamless environment creation to builds annoying.

Clang-format is available via PyPI (https://pypi.org/project/clang-format/) and should probably be taken from there instead. We currently already acquire it for use in .pre-commit-config via PyPI.

One question to reviewers is whether we go always with the most modern version, or if we should set it to what is used in the pre-commit hook.

All other extractions (via conda etc) are removed from the non-CondaRecipes CI jobs. This will require a private CI run to verify impact there.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@david-cortes-intel
Copy link
Contributor

One question to reviewers is whether we go always with the most modern version, or if we should set it to what is used in the pre-commit hook.

I say better to stick to the same version everywhere, to avoid surprises.

@ahuber21
Copy link
Contributor

I agree. I just had the case that some clang-format defaults changed between version 15 and today, which caused some problems in another repo. So better to just pin it.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
azure 79.76% <ø> (ø)
github 73.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icfaust icfaust marked this pull request as ready for review June 17, 2025 22:23
@icfaust
Copy link
Contributor Author

icfaust commented Jun 18, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Jun 18, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Jun 18, 2025

/intelci: run

1 similar comment
@icfaust
Copy link
Contributor Author

icfaust commented Jun 19, 2025

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants