Skip to content

[CI, bugfix] correct stability issues in CondaRecipes (backport #2493) #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rls/2025.6.0-rls
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 16, 2025

Description

conda update --all is known to be unstable. It is not guaranteed that all packages updated will properly work together even though they may pass the conda dependency checks.

Such was the case with ctypes on WindowsCondaRecipe.

The update conda step now properly does as stated, and follows the convention in CondaEnv CI testing.

NOTE: tests that were introduced in #2452 caused timeouts in this CI job, and must be disabled temporarily.

performance benchmarks unnecessary.

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).


This is an automatic backport of pull request #2493 done by [Mergify](https://mergify.com).

* Update conda-recipe-lnx.yml

* Update conda-recipe-win.yml

* Update conda-recipe-lnx.yml

* Update conda-recipe-win.yml

* Update test_model_builders.py

* Update test_model_builders.py

* Delete tests/test_model_builders.py

* Revert "Delete tests/test_model_builders.py"

This reverts commit 453dd88.

* disable catboost and check

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

* Update test_model_builders.py

(cherry picked from commit 2494172)

# Conflicts:
#	tests/test_model_builders.py
@mergify mergify bot added the conflicts label Jun 16, 2025
Copy link
Author

mergify bot commented Jun 16, 2025

Cherry-pick of 2494172 has failed:

On branch mergify/bp/rls/2025.6.0-rls/pr-2493
Your branch is up to date with 'origin/rls/2025.6.0-rls'.

You are currently cherry-picking commit 2494172.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .ci/pipeline/conda-recipe-lnx.yml
	modified:   .ci/pipeline/conda-recipe-win.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/test_model_builders.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
azure 79.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants