Skip to content

Add NearestNeighbors SPMD API #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Jun 17, 2025

Description

Adds spmd NearestNeighbors to API with necessary modifications to sklearnex/spmd and onedal/spmd, along with minor revisions in onedal4py and onedal itself (uxlfoundation/oneDAL#3262 - which is prerequisite for merging this). Test also added for validation.

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onedal/spmd/neighbors/neighbors.py 66.66% 2 Missing and 2 partials ⚠️
Flag Coverage Δ
azure 80.05% <75.00%> (+0.12%) ⬆️
github 71.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/neighbors/neighbors.py 81.20% <100.00%> (ø)
onedal/spmd/neighbors/__init__.py 100.00% <100.00%> (ø)
onedal/spmd/neighbors/neighbors.py 61.66% <66.66%> (+1.25%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ethanglaser
Copy link
Contributor Author

ethanglaser commented Jun 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant