-
Notifications
You must be signed in to change notification settings - Fork 135
CORE-AAM: Update AX API's mapping for aria-multiselectable #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@rahimabdi can you take a look, since it seems @cookiecrook is low on time for ARIA right now? |
core-aam/index.html
Outdated
@@ -8437,7 +8437,7 @@ <h4 id="ariaMultiselectableTrue"><code>aria-multiselectable</code>=<code>true</c | |||
<tr> | |||
<th><abbr title="macOS Accessibility Protocol">AX API</abbr></th> | |||
<td> | |||
<span class="property not-mapped"><a href="#not_mapped">Not mapped</a></span | |||
<span class="property">Property: <code>AXIsMultiSelectable</code>: <code>1</code></span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spectranaut This looks correct however it's unclear what the "1" value is for:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks @rahimabdi ! you are right, it should be YES, fixed and removed the errant prettier commit
Sure thing! I've left a PR comment. As a heads-up, it looks like Prettier has added an additional commit with unrelated changes... |
c20919f
to
3a36fde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rahim and Val
Closes w3c/core-aam#244
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff