[css-regions-1] Tidy up values & fix build errors. #12445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astearns
approved these changes
Jul 3, 2025
keithamus
added a commit
to csskit/csskit
that referenced
this pull request
Jul 3, 2025
I noticed that `flow-from` and `flow-into` were using `<ident>` which is wrong, so I fixed upstream in w3c/csswg-drafts#12445. That merged, so running `mise run generate-values regions` updated the `mod.rs` to this, which means we can uncomment `flow-from` at least!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this is one of the only grammars using
<ident>, and when I looked up<ident>it said:So I went to try and change them to
<custom-ident>but unfortunately trying to runbikeshed, I was confronted with some minor build errors - so I've tidied those up too.While I was at it, I figured I'd also add some definition data for the keywords of the style values, which makes it a little more convenient to link to.