-
Notifications
You must be signed in to change notification settings - Fork 55
emulation.setScreenOrientationOverride
#925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
emulation.setOrientationOverride
07ef816
to
4f7d996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
emulation.setOrientationOverride
emulation.setOrientationOverride
4e5592e
to
39268e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine for me as well. But there is one thing which doesn't look correct to me. Please see the inline comment.
emulation.setOrientationOverride
emulation.setScreenOrientationOverride
7bec7c1
to
d1d5f8e
Compare
@whimboo is it still blocking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. Otherwise it looks good. Thank you @sadym-chromium!
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
ee0167d
to
2a99338
Compare
…Override`, a=testonly Automatic update from web-platform-tests [wdspec] `emulation.setScreenOrientationOverride` (#53327) Spec: w3c/webdriver-bidi#925 -- wpt-commits: aff2901f5d21af68b0df8746bcc5d50dbf070e0b wpt-pr: 53327
…Override`, a=testonly Automatic update from web-platform-tests [wdspec] `emulation.setScreenOrientationOverride` (#53327) Spec: w3c/webdriver-bidi#925 -- wpt-commits: aff2901f5d21af68b0df8746bcc5d50dbf070e0b wpt-pr: 53327
…Override`, a=testonly Automatic update from web-platform-tests [wdspec] `emulation.setScreenOrientationOverride` (#53327) Spec: w3c/webdriver-bidi#925 -- wpt-commits: aff2901f5d21af68b0df8746bcc5d50dbf070e0b wpt-pr: 53327
WPT tests: web-platform-tests/wpt#53327
Preview | Diff