Skip to content

emulation.setScreenOrientationOverride #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 26, 2025
Merged

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented May 23, 2025

@sadym-chromium sadym-chromium changed the title Sadym/emulate orientation emulation.setOrientationOverride May 23, 2025
@sadym-chromium sadym-chromium force-pushed the sadym/emulate-orientation branch from 07ef816 to 4f7d996 Compare May 23, 2025 11:37
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine for me as well. But there is one thing which doesn't look correct to me. Please see the inline comment.

@whimboo whimboo changed the title emulation.setOrientationOverride emulation.setScreenOrientationOverride May 27, 2025
@sadym-chromium sadym-chromium requested a review from whimboo May 28, 2025 08:36
@sadym-chromium
Copy link
Contributor Author

@whimboo is it still blocking?

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Otherwise it looks good. Thank you @sadym-chromium!

@sadym-chromium sadym-chromium force-pushed the sadym/emulate-orientation branch from ee0167d to 2a99338 Compare June 26, 2025 07:29
@sadym-chromium sadym-chromium merged commit f8595a0 into main Jun 26, 2025
5 checks passed
@sadym-chromium sadym-chromium deleted the sadym/emulate-orientation branch June 26, 2025 07:59
github-actions bot added a commit that referenced this pull request Jun 26, 2025
SHA: f8595a0
Reason: push, by sadym-chromium

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sadym-chromium added a commit to web-platform-tests/wpt that referenced this pull request Jun 26, 2025
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Jul 4, 2025
…Override`, a=testonly

Automatic update from web-platform-tests
[wdspec] `emulation.setScreenOrientationOverride` (#53327)

Spec: w3c/webdriver-bidi#925
--

wpt-commits: aff2901f5d21af68b0df8746bcc5d50dbf070e0b
wpt-pr: 53327
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 4, 2025
…Override`, a=testonly

Automatic update from web-platform-tests
[wdspec] `emulation.setScreenOrientationOverride` (#53327)

Spec: w3c/webdriver-bidi#925
--

wpt-commits: aff2901f5d21af68b0df8746bcc5d50dbf070e0b
wpt-pr: 53327
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jul 9, 2025
…Override`, a=testonly

Automatic update from web-platform-tests
[wdspec] `emulation.setScreenOrientationOverride` (#53327)

Spec: w3c/webdriver-bidi#925
--

wpt-commits: aff2901f5d21af68b0df8746bcc5d50dbf070e0b
wpt-pr: 53327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants