-
Notifications
You must be signed in to change notification settings - Fork 653
[bazel] Clean up bazel scripts #7984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments before I dig in further tomorrow. Thanks for posting this!
WORKSPACE
Outdated
name = "bzlmodrio-libssh", | ||
sha256 = "65caef82554617403a16c79e8bcac6553d40eca3e23197e63275bba22db7d5b5", | ||
strip_prefix = "bzlmodRio-libssh-8405fbd5eb4e42b495f08f6ccf6fbbe5ced28bb7", | ||
urls = ["https://github.com/bzlmodrio/bzlmodRio-libssh/archive/8405fbd5eb4e42b495f08f6ccf6fbbe5ced28bb7.tar.gz"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this in the wpilibsuite org? Or move it into it?
cscore/build_examples.bzl
Outdated
"usbviewer", | ||
] | ||
|
||
def build_cpp_examples(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI,
[
cc_library(name = f, ...) for f in ['a', 's' ,'d', 'f']
]
works in BUILD files.
Hey @pjreiniger , the rest of it looks good, could you address those 2 comments, then let's merge? |
This is a big cleanup of some of the things Austin has seen as he is getting up to speed, as well as prep work for future efforts like publishing and eventualy bazel version upgrades.
incompatible_disallow_empty_glob
will be enabled by default in bazel 8, and there were quite a few places that were providing no files in the 2027 branch.//wpiutil:__subpackages__
. Since the build files are monolithic that does basically nothing, so I deleted visibility which makes it package private.no-roborio
/manual
/ etc tags, because they would break during cross compilation. This updates all of those locations to usetarget_compatible_with
instead.With these changes the bazel coverage should be everything except
wpical
andntcoreffi