[bazel] Create better static libraries and add basic packaging for eventual publishing. #8029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: ntcore
AustinSchuh
reviewed
Jun 17, 2025
| linker_inputs = [] | ||
| for linker_input in dependency_linker_inputs: | ||
| for lib in linker_input.libraries: | ||
| for o in lib.objects + lib.pic_objects: |
There was a problem hiding this comment.
FYI, with -c opt on Linux, I think this needs to be one or the other. I've seen both populated. Happy to be wrong if you've dug deeper and know what I saw.
AustinSchuh
reviewed
Jun 17, 2025
| output_file = ctx.actions.declare_file(ctx.attr.static_lib_name) | ||
| else: | ||
| folder, lib = _folder_prefix(ctx.label.name) | ||
| output_file = ctx.actions.declare_file(folder + "/lib" + lib + ".a") |
There was a problem hiding this comment.
Mind putting a TODO here on .lib vs .a?
AustinSchuh
reviewed
Jun 17, 2025
| feature_configuration = cc_common.configure_features( | ||
| ctx = ctx, | ||
| cc_toolchain = cc_toolchain, | ||
| requested_features = ctx.features + ["force_no_whole_archive"], |
There was a problem hiding this comment.
Mind a quick comment on what force_no_whole_archive does for us here?
|
I'm happy with TODOs for some of these things too. I mostly don't want to lose the open threads. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a watered down version of a combo of #8025 and #7971. Austins PR will have some work to do to get it working on windows, and my publishing PR should be superseded by his (unpublished) work with the
rules_jvm_external.Since a large portion of his PR is library renames for easier publishing, and adding the smarter static libraries, this rips out just those relevant bits while the windows shared library problem can be worked on. separately