niri-taskbar: Initial Module Implementation #4164
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugs: - Old Niri Untested. - It seems like IPC handling in niri/backend needs to be updated to support the new indicies properly. Moving windows often leads to stale data. - Icons for some flatpak apps (Like obsidian on my laptop) do not work. - Using niri dev branch.
- Add separators when showing multiple workspaces - Add failover if app icon not found
X Applications often use their "StartupWMClass" names from their desktop files. In these cases, we need to parse through the desktop files to get the "Icon" name (which is typically their real app id). This occurs with all X based flatpak apps, since the underlying app id (e.g. "com.myapp.desktop") almost never aligns with the StartupWMClass.
Keep track of buttons and workspaces with their own classes. This should help to allow us to better apply workspace specific styles. It should also allow us to more easily optimize performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a taskbar that is specific for Niri. Unlike wlr-taskbar, this taskbar provides the ability to order applications by position in the Niri workspace; Groups applications by their workspace; and uses exclusively Niri IPC building on the implementation of the existing niri-workspaces module.
NOTE: This depends on an unmerged Niri PR, YaLTeR/niri#1265