Corrected PointerPointProperties inline documentation, and exposed it on PointerEventArgs
#19062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made PointerEventArgs.Properties public, to better support pattern matching
TomEdwardsEnscape
force-pushed
the
fixes/PointerPointInlineDocumentation
branch
from
f0cd246 to
af6230d
Compare
|
You can test this PR using the following package version. |
MrJul
added
enhancement
backport-candidate-11.3.x
MrJul
approved these changes
Jun 17, 2025
MrJul
pushed a commit
that referenced
this pull request
Jun 24, 2025
Made PointerEventArgs.Properties public, to better support pattern matching
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some minor problems with
PointerPointPropertieswhile adding input handling code. This PR addresses them.The inline documentation of the various "IsXPressed" properties claimed that they indicated "whether the pointer input was triggered" by that button. This was wrong, as their values only indicate whether the relevant button was pressed at the time the event occurred. It's the
PointerUpdateKindproperty which indicates which button press/release triggered the event.The only way to get a
PointerPointPropertiesobject for a pointer event was to call theGetCurrentPointmethod. This frustrates pattern matching, which only works with properties. There is no reason to hide an event's pointer properties behind a method because they are immutable, so I changed the existing property which stores them fromprotectedtopublic.What is the updated/expected behavior with this PR?
No changes to behaviour.
Breaking changes
None
Obsoletions / Deprecations
None