[Avalonia.Controls] feature: Remove the need for MenuItem Icon to be a ILogical #19075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
MrJul
added
enhancement
backport-candidate-11.3.x
No worries. We usually ask to avoid unnecessary reformatting, but trimming white spaces is acceptable. |
MrJul
approved these changes
Jun 17, 2025
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allow any type to be used as
MenuItem.Iconas it's already ofobject?type and displayed using aContentPresenterin various themes/styles.What is the current behavior?
Currently, if the value is not a
ILogical, the pseudo class:iconwon't be set and the icon won't be displayed.What is the updated/expected behavior with this PR?
The pseudo class change now only check weither the value is not null, allowing to display anything as icon and relying on data template for more possibilities.
Fixed issues
Fixes #19063
It seems my ide config cleaned up some white space in the process, tell me if I should only keep the
IconChangedpart :)