A file is missing or not transferred to github pages

[maxkostin]

Describe the bug

A file is missing from the destination folder: the action is run with no errors, but one file is missing/not transferred to the github pages (_commonjsHelpers-725317a4.js). Setting clean: false or clean: true makes no difference. When running npm run build-storybook locally, all files are there.

Workflow

name: Publish edge version

on:
  push:
    branches:
      - "master"
  pull_request:

concurrency: ${{ github.ref }}

jobs:
  publish:
    name: Publish edge version
    runs-on: ubuntu-latest
    environment: nonprod
    env:
      NODE_AUTH_TOKEN: ${{ secrets.SS }}

    steps:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          token: ${{ secrets.SS }}

      - name: Use node 16 and npm
        uses: actions/setup-node@v3
        with:
          node-version: "16.x"
          registry-url: https://npm.pkg.github.com
          scope: myscope
          cache: "npm"

      - name: Install
        run: npm i

      - name: Build, test, quality check
        run: npm run build

      - name: Build strorybook
        run: npm run build-storybook

      - name: Determine new version type (major | minor | patch)
        id: new-version-type
        env:
          COMMIT_MSG: ${{ github.event.commits[0].message }}
        run: |
          NEW_VERSION_TYPE='patch'
          if [[ $COMMIT_MSG == feat:* ]] || [[ $COMMIT_MSG == feat\(* ]];
          then
          NEW_VERSION_TYPE='minor'
          fi
          if [[ $COMMIT_MSG =~ "BREAKING CHANGE" ]];
          then
          NEW_VERSION_TYPE='major'
          fi
          echo "::set-output name=version_type::$NEW_VERSION_TYPE"

      - name: Configure git
        run: |
          git config --global user.email "abc@abc.com"
          git config --global user.name "abc"
          git config --global push.followTags true
          git config --global pull.rebase true

      - name: Bump package.json version in workspace
        id: bump-version
        run: npm version ${{ steps.new-version-type.outputs.version_type }} -m "(chore) bump to version %s [skip actions]"

      - name: Push version commit
        if: github.ref == 'refs/heads/master'
        run: |
          git push

      - name: Publish edge version
        if: github.ref == 'refs/heads/master'
        run: |
          npm publish --tag edge

      - name: Publish stories
        uses: JamesIves/github-pages-deploy-action@v4.4.3
        with:
          branch: docs
          folder: storybook-static
          clean: false

[iammary]

@maxkostin have you found a workaround for this? I am experiencing the same issue in our github-actions :(

[JamesIves]

Is this happening with a specific type of file? For example only files starting with the underscore prefix?

I'm also wondering if you can run ls on the directory because the deploy action runs to validate that these files are correctly being generated at the location you expect them to be.

[iammary]

Thanks for pointing out @JamesIves

Yes the file is there and its jekyll not building files with underscore is the issue: https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll#configuring-jekyll-in-your-github-pages-site

What solved my issue is adding this in our github action step

- name: Build Storybook 🧩
   run: npm run build-storybook

- name: Add nojekyll file to read underscore files 📋
   run: cd storybook-static && touch .nojekyll

[maxkostin]

@iammary, run: cd storybook-static && touch .nojekyll certainly fixes the issue, cheers!

[JamesIves]

Interesting! Glad you were able to resolve the issue!

Going to mark this as a potential GitHub issue.