Fix deployment done if FOLDER is part of the files under source control #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLKiiwy
force-pushed
the
fix-folder-part-of-versionned
branch
6 times, most recently
from
e9c3e52 to
96fcdc8
Compare
|
I'll give this a test later today, thanks for the PR! |
MLKiiwy
force-pushed
the
fix-folder-part-of-versionned
branch
14 times, most recently
from
e29f71c to
bfa4043
Compare
MLKiiwy
force-pushed
the
fix-folder-part-of-versionned
branch
from
bfa4043 to
46435ee
Compare
|
I have tested it and update the description of my PR. |
JamesIves
reviewed
Oct 17, 2019
| echo "Deploying to GitHub..." | ||
| git fetch origin | ||
| echo "Prepare" | ||
| rm -rf folder_for_deployment |
There was a problem hiding this comment.
Do we need to delete the deployment folder once you fetch from the origin? Presumably it doesn't exist yet right?
There was a problem hiding this comment.
yep it's not required your right
|
Superseded by #44 - Thanks so much for the PR and insight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the specified FOLDER is part of the files under git source control, the script is not able to add them, resulting of an empty commit ... and failing to deploy.
Here we create a new worktree from the folder we want to deploy.
We add everything missing in this folder and we push.
It's related to #36
I also change the initialization of the gh-pages branch with only git command.
Testing Instructions
I have tested it with repo.
It's working fine, it's also adding a small feature now the gh-pages branch is also versionned with all deployed versions.
Issue with new worktree initialisation
But I'm not super happy by the fact that I have to recreate a branch after switching to the new worktree ...
On local when I create a worktree from a branch, if I go into this new worktree I'm already on the branch if it exists.
Here after few tests it's not really the case, I'm in a detached state (+ I have to specified the remote to worktree add command).
Maybe I'm missing something