Skip to content

Use $BASE_BRANCH instead of master #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2019

Conversation

jaiselrahman
Copy link
Contributor

Description

Use $BASE_BRANCH instead of master in git subtree command

@jaiselrahman
Copy link
Contributor Author

master branch gets deleted if $BASE_BRANCH is set to master

Deploying to GitHub...
[src 3c4b337] Deploying to master - 16:36:25
 8 files changed, 21 insertions(+)
 create mode 100644 dist/css/app.1180ca5c.css
 create mode 100644 dist/favicon.ico
 create mode 100644 dist/img/logo.82b9c7a5.png
 create mode 100644 dist/index.html
 create mode 100644 dist/js/app.eb5dcca5.js
 create mode 100644 dist/js/app.eb5dcca5.js.map
 create mode 100644 dist/js/chunk-vendors.80d27098.js
 create mode 100644 dist/js/chunk-vendors.80d27098.js.map

-  Building for production...
1/1 (0)
No new revisions were found
To https://github.com/jaiselrahman/jaiselrahman.github.io.git
 - [deleted]         master
Deployment succesful!

### SUCCEEDED Deploy to master 16:36:32Z (1m7.809s)

@JamesIves
Copy link
Owner

JamesIves commented May 17, 2019

Thanks for the pull request!

$BASE_BRANCH should default to master as it's not a required variable, can you push up a change so that's the default behavior if the variable doesn't exist?

@jaiselrahman
Copy link
Contributor Author

Fixed, Now $BASE_BRANCH will default to master

@JamesIves
Copy link
Owner

Perfect, thank you!

@JamesIves JamesIves merged commit 46b5976 into JamesIves:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants