add fma #106
Open
add fma #106
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
===========================================
- Coverage 96.95% 82.74% -14.22%
===========================================
Files 3 2 -1
Lines 197 197
===========================================
- Hits 191 163 -28
- Misses 6 34 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giordano
reviewed
Jun 20, 2025
src/bfloat16.jl
Outdated
| @@ -440,5 +440,7 @@ for F in (:abs, :abs2, :sqrt, :cbrt, | |||
| end | |||
| end | |||
|
|
|||
| Base.fma(x::BFloat16, y::BFloat16, z::BFloat16) = BFloat16(fma(Float32(x), Float32(y), Float32(z))) | |||
There was a problem hiding this comment.
This looks very inefficient on hardware with native bf16 support.
There was a problem hiding this comment.
Something like
ccall("llvm.fma.bf16", llvmcall, BFloat16, (BFloat16, BFloat16, BFloat16), x, y, z)would be better (although this should probably be handled by julia's codegen directly)
There was a problem hiding this comment.
why not just use llvmcall?
There was a problem hiding this comment.
That would be better --
I was not sure it worked correctly (at one time it did not).
I am making the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.