Add APIs exposed in ShadowRealms #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in today's meeting, this PR adds the `CustomEvent`, `globalThis.reportError()` and `globalThis.self` APIs to the Minimum Common API. This is done because they will be exposed in ShadowRealms in browsers, and it is useful for code running in ShadowRealms to also be able to run in server-side runtimes.
jasnell
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in today's meeting, this PR adds the
CustomEvent,globalThis.reportError()andglobalThis.selfAPIs to the Minimum Common API. This is done because they will be exposed in ShadowRealms in browsers, and it is useful for code running in ShadowRealms to also be able to run in server-side runtimes.