Clarify that the empty string is returned if no cache is restored. #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinara255
approved these changes
Dec 11, 2024
TheGiraffe3
approved these changes
Dec 11, 2024
|
Hey @Dinara255 @TheGiraffe3, could you please merge this PR? |
Hi @PaulRBerg, thanks for your comment! If I'm not mistaken, neither @Dinara255 nor @TheGiraffe3 are maintainers of this repo (do correct me if I'm wrong). Maybe we should ping @salmanmkc or @robherley, who have recent contributions to the project. Btw, a more thorough explanation, with code snippets, can be found on the original issue: #1513 |
|
See also the fate of my related PR on this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1513
Description
Update documentation, so that it reflects the actual behavior of
cache-hit.Motivation and Context
The documentation describes a behavior that does not reflect the actual implementation. This caused quite a headache when trying to debug this action.
How Has This Been Tested?
I updated my
.ymlso that they follow the logic in this PR and they worked correctly.Types of changes
Checklist: