Remove Support for older .NET Versions and Update installers scripts #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated .NET versions from installation scripts, updates documentation and CI workflows to target current supported versions (6.0–9.0), and adjusts E2E tests accordingly.
- Removed “signed” and “validated” quality options from Bash/PowerShell installers and cleaned up obsolete URL sanitization code.
- Updated README examples and GitHub Actions matrices to reflect .NET 8.0 and 9.0 support.
- Extended test mappings and E2E workflows to cover .NET 9.0 and removed older version checks.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| externals/install-dotnet.sh | Dropped old quality labels, added retry bug workaround, removed URL sanitization helpers. |
| externals/install-dotnet.ps1 | Removed deprecated qualities, stripped obsolete sanitization functions. |
| tests/verify-dotnet.ps1 | Added mapping for "9.0" = "net9.0". |
| README.md | Swapped references from 3.x/5.x to 8.x/9.x in examples and version syntax. |
| .github/workflows/test-dotnet.yml | Updated dotnet-version matrix to ['6.0','7.0','8.0','9.0']. |
| .github/workflows/e2e-tests.yml | Replaced all 2.x/3.x/5.x setup steps with 6.x–9.x, adjusted verify patterns. |
Comments suppressed due to low confidence (1)
externals/install-dotnet.sh:1797
- [nitpick] Casing is inconsistent: the script error lists 'ga' in lowercase but this usage help shows 'GA' uppercase. Normalize casing to avoid confusion (e.g., use lowercase 'ga' everywhere).
echo " The possible values are: daily, preview, GA."
priyagupta108
approved these changes
Jun 23, 2025
aparnajyothi-y
approved these changes
Jun 23, 2025
gowridurgad
changed the title
HarithaVattikuti
approved these changes
Jun 24, 2025
COMPUTERS-bit
pushed a commit
to COMPUTERS-bit/setup-dotnet
that referenced
this pull request
Jun 26, 2025
Co-authored-by: “gowridurgad” <“hgowridurgad@github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
npm run update-installers.Related issue:
#645
Check list: