Add board NanoPi R3S LTS #8300
Add board NanoPi R3S LTS #8300
Conversation
The LTS variant has an HDMI port. Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
pyavitz
requested review from
NicoD-SBC,
SuperKali,
TheSnowfield,
Tonymac32,
amazingfate,
catalinii,
igorpecovnik,
rpardini,
ColorfulRhino,
JohnTheCoolingFan,
TRSx80,
ahoneybun,
brentr,
clee,
efectn,
joekhoobyar,
krachlatte,
lanefu,
paolosabatino,
prahal and
schwar3kat
as code owners
|
""" WalkthroughA new board configuration file for the NanoPi R3S LTS device has been introduced. This file specifies board metadata, kernel targets, device tree information, partition table type, and boot scenario. It includes a function to configure the board to use the mainline U-Boot bootloader for certain branches, specifying the U-Boot version, adjusting bootloader settings, and defining how the U-Boot binary is written to the target device. The function also clears any custom post-processing hooks to ensure the mainline U-Boot build process is used as-is. Additionally, the Real-Time Clock (RTC) driver HYM8563 configuration was changed from built-in to module in the linux-rockchip64 kernel configs for both current and edge branches. Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (1)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
size/large
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
config/boards/nanopi-r3s-lts.conf (2)
5-6:BOOTCONFIGis set twice – second assignment is redundant
BOOTCONFIGis given the same value on line 5 and again insidepost_family_config__use_mainline_uboot(line 18). Duplicating the assignment is unnecessary and slightly obscures intent.-BOOTCONFIG="nanopi-r3s-lts-rk3566_defconfig"You can safely drop the first assignment and keep the one inside the conditional helper, or vice-versa, to reduce noise.
14-16: Quote variable in conditional to avoid accidental word-splittingEven though
BRANCHis expected to be a single token, quoting is a cheap guard-rail and keeps the style consistent with the rest of Armbian configs.-if [[ "$BRANCH" != "current" && "$BRANCH" != "edge" ]]; then +if [[ "${BRANCH}" != "current" && "${BRANCH}" != "edge" ]]; then
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
patch/kernel/archive/rockchip64-6.12/dt/rk3566-nanopi-r3s-lts.dtsis excluded by!patch/**patch/kernel/archive/rockchip64-6.15/dt/rk3566-nanopi-r3s-lts.dtsis excluded by!patch/**patch/u-boot/v2025.04/board_nanopi-r3s-lts/Add-board-NanoPi-R3S-LTS.patchis excluded by!patch/**
📒 Files selected for processing (1)
config/boards/nanopi-r3s-lts.conf(1 hunks)
🔇 Additional comments (1)
config/boards/nanopi-r3s-lts.conf (1)
23-24: Verify thatRKBIN_DIR,BL31_BLOB, andDDR_BLOBare always defined
UBOOT_TARGET_MAPdepends on three family-level variables. If any of them are undefined for this new board, the build will fail late and confusingly.Please double-check that:
config/sources/families/rk35xx.conf(or equivalent) sets these three vars, or- This board file sets fallbacks when they are missing.
Otherwise consider adding a guard:
: "${RKBIN_DIR:?RKBIN_DIR not set}" : "${BL31_BLOB:?BL31_BLOB not set}" : "${DDR_BLOB:?DDR_BLOB not set}"
Change from "y" to "m" Before [ 2.423992] rtc-hym8563 1-0051: no valid clock/calendar values available [ 2.424718] rtc-hym8563 1-0051: registered as rtc0 [ 2.425770] rtc-hym8563 1-0051: no valid clock/calendar values available [ 2.425789] rtc-hym8563 1-0051: hctosys: unable to read the hardware clock [ 3.817166] rk808-rtc rk808-rtc.5.auto: registered as rtc1 After [ 3.790107] rk808-rtc rk808-rtc.5.auto: registered as rtc0 [ 3.801742] rk808-rtc rk808-rtc.5.auto: setting system clock to 2017-08-05T09:48:13 UTC (1501926493) [ 3.919628] rtc-hym8563 1-0051: registered as rtc1 Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
github-actions
bot
removed
the
Ready to merge
|
add hdmi port and call it lts LOL |
|
forums+tag added. |
|
Tested from here https://fi.mirror.armbian.de/incoming/pyavitz/nanopi-r3s-lts/archive/ ? |
|
no, diy with both current and edge. |
The LTS variant has an HDMI port.