[Bug]: armbian-config does not take care about overlay_prefix

[Race666]

What happened?

I installed armbian on a Orange Pi Zero and have enabled the uart 1 and 2 overlay by armbian-config.

 [*] sun8i-h3-uart1
 [*] sun8i-h3-uart2             

This does not work because in /boot/armbianEnv.txt a preconfigured prefix is set

overlay_prefix=sun8i-h3

armbian-config sets

overlays=sun8i-h3-uart1 sun8i-h3-uart2

and this causes that the load of the overlays fails because the loader searches for

/boot/dtb/overlay/sun8i-h3-sun8i-h3-uart1.dtbo
/boot/dtb/overlay/sun8i-h3-sun8i-h3-uart2.dtbo

instead of

/boot/dtb/overlay/sun8i-h3-uart1.dtbo
/boot/dtb/overlay/sun8i-h3-uart1.dtbo

How to reproduce?

• Install https://www.armbian.com/orange-pi-zero/
• start armbian-config
• enable overlays sun8i-h3-uart1 and sun8i-h3-uart2

this results in a /boot/armbianEnv.txt

verbosity=1
bootlogo=false
console=both
disp_mode=1920x1080p60
overlay_prefix=sun8i-h3
overlays=sun8i-h3-uart1 sun8i-h3-uart2
rootdev=UUID=aec93845-9ef3-416e-ba6a-9f6e099bce15
rootfstype=ext4
...

and the path for loading the overlays is like this:

/boot/dtb/overlay/$OVERLAYPREFIX/$OVERLAY

if I set

verbosity=1
bootlogo=false
console=both
disp_mode=1920x1080p60
overlay_prefix=sun8i-h3
overlays=uart1 uart2
rootdev=UUID=aec93845-9ef3-416e-ba6a-9f6e099bce15
rootfstype=ext4
...

it works as expected.

On which OS are you observing this problem? (for easier diagnosis please provide logs with armbianmonitor -u)

Armbian Debian 12 Bookworm

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Hey @Race666 !

Looks like it's your first time interacting with Armbian here on GitHub.

Welcome and thank you for taking the time to report an issue ❤️.

Don't forget to star ⭐ the repo.

[sp2ong]

It was solved

#344

but It looks like bug with overlay_prefix back again

[TMSL]

I believe I've tracked down the issue. The same problem happens on my Libre Renegade board:

1. When armbian-config adds the overlay to armbianEnv.txt the prefix is included in the overlay name. The overlay won't be applied because the prefix in armbianEnv.txt gets added again when attempting to apply the module.
2. deleting the prefix from the overlay name in armbianEnv.txt will allow the overlay to be applied, but then the overlay ON status "*" does not show up correctly in armbian-config. Selecting "save" in armbian-config will cause the 'corrected' overlay name to be deleted from armbianEnv.txt.

The fix appears to be to modify config.system.sh to:

• delete the prefix if it is present in the name overlay from available_overlays before comparing it against the overlaynames from the "overlays=" line in armbianEnv.txt
• delete the prefix when writing the overlay names to armbianEnv.txt.

I tested the following changes to config.system.sh and they fix problems with overlay loading and correct operation in armbian-config on my system. However, I don't have testing for other systems so I made it conditional on $BOARDFAMILY, although I think these changes can be universally applied since they should only affect overlays where the prefix is part of the overlay (.dtbo) name.

for overlay in ${available_overlays}; do
	local status="OFF"
	grep '^overlays' ${overlayconf} | grep -qw ${overlay} && status=ON
	# Raspberry Pi
	grep '^dtoverlay' ${overlayconf} | grep -qw ${overlay} && status=ON
	# NEW -------- subtract overlay_prefix from candidate before compare
	if [[ $BOARDFAMILY == "rockchip64" ]]; then
		candidate=$(echo $overlay | sed "s/^$overlay_prefix"-"//g")
		grep '^overlays' ${overlayconf} | grep -qw ${candidate} && status=ON
	fi
	# -----------
	options+=( "$overlay" "" "$status")
done

case $exit_status in
	0)
		changes="true"
		newoverlays=$(echo $selection | sed 's/"//g')
		# NEW --------
		if [[ $BOARDFAMILY == "rockchip64" ]]; then
			# subtract prefix from newoverlays
			newoverlays=$(echo $newoverlays | sed "s/^$overlay_prefix"-"//" \
				| sed "s/ $overlay_prefix"-"/ /g")
			newoverlays=$(echo $newoverlays | tr -s ' ') #trim extra spaces, if any
		fi
		# ------------
		# Raspberry Pi
		if [[ "${LINUXFAMILY}" == "bcm2711" ]]; then
	... ETC.

[TMSL]

I'm running:

BOARD=renegade
BOARD_NAME="Renegade"
BOARDFAMILY=rockchip64
BUILD_REPOSITORY_URL=https://github.com/armbian/build
BUILD_REPOSITORY_COMMIT=ffe959bb1
LINUXFAMILY=rockchip64
ARCH=arm64
BOOT_SOC=rk3328
IMAGE_TYPE=stable
BOARD_TYPE=conf
INITRD_ARCH=arm64
KERNEL_IMAGE_TYPE=Image
KERNEL_TARGET=current,edge
KERNEL_TEST_TARGET=current
FORCE_BOOTSCRIPT_UPDATE=
FORCE_UBOOT_UPDATE=
OVERLAY_DIR="/boot/dtb/rockchip/overlay"
VENDOR="Armbian"
VENDORDOCS="https://docs.armbian.com"
VENDORURL="https://www.armbian.com"
VENDORSUPPORT="https://forum.armbian.com"
VENDORBUGS="https://www.armbian.com/bugs"
BOOTSCRIPT_FORCE_UPDATE="no"
BOOTSCRIPT_DST="boot.cmd"
VERSION=25.2.2
REVISION=25.2.2