-
Notifications
You must be signed in to change notification settings - Fork 561
support depends_on in terragrunt generation #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce enhanced authentication logic in the API middleware, add dependency ordering support to Terragrunt project configuration parsing, and extend a configuration struct with a new field to control dependency ordering behavior. No public function signatures were altered; all updates are internal or additive. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Middleware
participant Auth
participant Handler
Client->>Middleware: HTTP Request with Authorization header
alt Authorization starts with "cli:"
Middleware->>Auth: CheckJobToken(token)
alt Token valid
Middleware->>Middleware: Set org ID, access level, job token in context
Middleware->>Handler: Forward request
else Token invalid
Middleware->>Client: Respond 403 Forbidden
end
else No "cli:" prefix
Middleware->>Middleware: Set default org ID/admin access
Middleware->>Handler: Forward request
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧬 Code Graph Analysis (2)backend/middleware/noop.go (2)
libs/digger_config/digger_config.go (2)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🔇 Additional comments (4)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added support for terragrunt project dependencies in Digger configuration through a new DependsOnOrdering
feature, enabling preservation of depends_on
relationships during project generation.
- Added
DependsOnOrdering
boolean field toTerragruntParsingConfig
inlibs/digger_config/yaml.go
for controlling dependency ordering - Modified
hydrateDiggerConfigYamlWithTerragrunt
function inlibs/digger_config/digger_config.go
to process and map terragrunt project dependencies
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
✅ No security or compliance issues detected. Reviewed everything up to 728a937. Security Overview
Detected Code Changes
Reply to this PR with |
support for depends_on during terragrunt genration and also fixed bug with NOOP auth not picking the right org when cli token is sent
Summary by CodeRabbit
New Features
Bug Fixes