Skip to content

support depends_on in terragrunt generation #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

motatoes
Copy link
Contributor

@motatoes motatoes commented Jun 25, 2025

support for depends_on during terragrunt genration and also fixed bug with NOOP auth not picking the right org when cli token is sent

Summary by CodeRabbit

  • New Features

    • Added support for capturing and assigning project dependency ordering information when parsing Terragrunt configurations.
    • Introduced an optional setting to enable or disable dependency ordering in configuration files.
  • Bug Fixes

    • Improved API authentication handling for CLI tokens, providing clearer error responses and logging for invalid tokens.

Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

Walkthrough

The changes introduce enhanced authentication logic in the API middleware, add dependency ordering support to Terragrunt project configuration parsing, and extend a configuration struct with a new field to control dependency ordering behavior. No public function signatures were altered; all updates are internal or additive.

Changes

File(s) Change Summary
backend/middleware/noop.go Enhanced NoopApiAuth middleware to validate "cli:" bearer tokens and set context on success.
libs/digger_config/digger_config.go Modified Terragrunt config hydration to capture and assign project dependency ordering information.
libs/digger_config/yaml.go Added DependsOnOrdering boolean pointer field to TerragruntParsingConfig struct.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Middleware
    participant Auth
    participant Handler

    Client->>Middleware: HTTP Request with Authorization header
    alt Authorization starts with "cli:"
        Middleware->>Auth: CheckJobToken(token)
        alt Token valid
            Middleware->>Middleware: Set org ID, access level, job token in context
            Middleware->>Handler: Forward request
        else Token invalid
            Middleware->>Client: Respond 403 Forbidden
        end
    else No "cli:" prefix
        Middleware->>Middleware: Set default org ID/admin access
        Middleware->>Handler: Forward request
    end
Loading

Poem

A token checked, a secret shared,
Now "cli:" jobs are well prepared.
With Terragrunt, dependencies bloom—
Configs now know who must resume.
A field appears, a flag is set,
The code hops forward—no regret!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dec859 and 728a937.

📒 Files selected for processing (3)
  • backend/middleware/noop.go (2 hunks)
  • libs/digger_config/digger_config.go (3 hunks)
  • libs/digger_config/yaml.go (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
backend/middleware/noop.go (2)
backend/middleware/middleware.go (1)
  • CheckJobToken (59-84)
backend/middleware/jwt.go (3)
  • ORGANISATION_ID_KEY (326-326)
  • ACCESS_LEVEL_KEY (329-329)
  • JOB_TOKEN_KEY (330-330)
libs/digger_config/digger_config.go (2)
libs/digger_config/terragrunt/atlantis/generate.go (1)
  • Parse (709-933)
libs/digger_config/yaml.go (1)
  • ProjectYaml (37-54)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Build
  • GitHub Check: Build
  • GitHub Check: Build
  • GitHub Check: Build
  • GitHub Check: Build
  • GitHub Check: Build
  • GitHub Check: Build
  • GitHub Check: Security Check
🔇 Additional comments (4)
libs/digger_config/yaml.go (1)

177-177: LGTM: Well-structured optional configuration field.

The new DependsOnOrdering field follows Go best practices with proper pointer type for optional behavior and appropriate YAML tags.

libs/digger_config/digger_config.go (2)

745-766: LGTM: Properly captures dependency mapping from atlantis parser.

The modification correctly captures the third return value projectDependsOnMap from atlantis.Parse. The function signature change aligns with the terragrunt/atlantis implementation that returns dependency information.


805-822: LGTM: Well-implemented conditional dependency assignment.

The refactored code properly:

  • Creates a local diggerProject variable for cleaner manipulation
  • Uses safe nil checking before dereferencing parsingConfig.DependsOnOrdering
  • Conditionally assigns dependencies from the parsed dependency map
  • Maintains the existing project creation flow

The implementation correctly enables dependency ordering when the feature flag is enabled.

backend/middleware/noop.go (1)

6-8: LGTM!

The new imports are appropriately used for the enhanced authentication logic.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch feat/support-depends-on-for-terragrunt-gen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added support for terragrunt project dependencies in Digger configuration through a new DependsOnOrdering feature, enabling preservation of depends_on relationships during project generation.

  • Added DependsOnOrdering boolean field to TerragruntParsingConfig in libs/digger_config/yaml.go for controlling dependency ordering
  • Modified hydrateDiggerConfigYamlWithTerragrunt function in libs/digger_config/digger_config.go to process and map terragrunt project dependencies

2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Copy link

delve-auditor bot commented Jun 25, 2025

No security or compliance issues detected. Reviewed everything up to 728a937.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► middleware/noop.go
    Added CLI token processing and verification
► digger_config/digger_config.go
    Added support for depends_on in terragrunt configuration
► digger_config/yaml.go
    Added DependsOnOrdering configuration option

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@motatoes motatoes changed the title support depends_on in terragrunt generatino support depends_on in terragrunt generation Jun 25, 2025
@motatoes motatoes merged commit 1c23cbd into develop Jun 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant