github: support cloud build URL when writing summary #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
gh-summary-cloud-driver
branch
from
a45e143 to
174076c
Compare
crazy-max
changed the title
nico1510
reviewed
May 22, 2025
src/github.ts
Outdated
| @@ -43,6 +43,8 @@ export interface GitHubOpts { | |||
| token?: string; | |||
| } | |||
|
|
|||
| const cloudBuildsURL = 'https://app.docker.com/build/accounts/docker/builds'; | |||
There was a problem hiding this comment.
I realize that I have the same mistake in my PR but we have to use a param for the account part (hard-coded to docker here). The account is part of the builder endpoint.
There was a problem hiding this comment.
Ah ok it's the builder name I assume?
There was a problem hiding this comment.
I think build and push action creates the builder with a -name flag right? So it might not be in the builder name.
There was a problem hiding this comment.
Ah yes this is part of the endpoint in setup-buildx-action: https://docs.docker.com/build-cloud/ci/#github-actions
There was a problem hiding this comment.
Updated, we would just need to pass driver and endpoint to write summary opts. Let me know what you think.
crazy-max
force-pushed
the
gh-summary-cloud-driver
branch
2 times, most recently
from
8a1abf0 to
618c852
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
gh-summary-cloud-driver
branch
from
618c852 to
b16fac0
Compare
nico1510
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/build-push-action#1370 (comment)
alternative and closes #685
For single build:
When there are multiple refs built (with bake-action), the build URL will be set within the summary table for each record.