Skip to content

Local registry example #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Local registry example #104

merged 4 commits into from
Sep 8, 2020

Conversation

crazy-max
Copy link
Member

No description provided.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi September 5, 2020 03:19
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't setup-buildx action better for this example?

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi September 5, 2020 13:34
@crazy-max
Copy link
Member Author

@tonistiigi

Isn't setup-buildx action better for this example?

I think in most cases the use of a local registry will involve pushing an image into it so in my opinion this example is better suited here.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit b2462f3 into docker:v2-working-branch Sep 8, 2020
@crazy-max crazy-max deleted the local-registry-example branch September 8, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants